Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7396C194FE for ; Thu, 17 Mar 2016 23:33:42 +0000 (UTC) Received: (qmail 90266 invoked by uid 500); 17 Mar 2016 23:33:42 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 90230 invoked by uid 500); 17 Mar 2016 23:33:42 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 90213 invoked by uid 99); 17 Mar 2016 23:33:41 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 23:33:41 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CC987DFC4F; Thu, 17 Mar 2016 23:33:41 +0000 (UTC) From: dblotsky To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-android pull request: CB-10600 'cordova run android --rele... Content-Type: text/plain Message-Id: <20160317233341.CC987DFC4F@git1-us-west.apache.org> Date: Thu, 17 Mar 2016 23:33:41 +0000 (UTC) Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/276#discussion_r56594805 --- Diff: bin/templates/cordova/lib/emulator.js --- @@ -363,8 +363,14 @@ module.exports.install = function(givenTarget, buildResults) { if (err) reject(new CordovaError('Error executing "' + command + '": ' + stderr)); // adb does not return an error code even if installation fails. Instead it puts a specific // message to stdout, so we have to use RegExp matching to detect installation failure. - else if (/Failure/.test(stdout)) reject(new CordovaError('Failed to install apk to emulator: ' + stdout)); - else resolve(stdout); + else if (/Failure/.test(stdout)) { + if (stdout.match(/INSTALL_PARSE_FAILED_NO_CERTIFICATES/)) { + stdout += 'Sign the build using \'-- --keystore\' or \'--buildConfig\'' + + ' or sign and deploy the unsigned apk manually using Android tools.'; + } + + reject(new CordovaError('Failed to install apk to emulator: ' + stdout)); + } else resolve(stdout); --- End diff -- Created a JIRA: https://issues.apache.org/jira/browse/CB-10903 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org