Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97E4818F29 for ; Thu, 17 Mar 2016 21:18:54 +0000 (UTC) Received: (qmail 53006 invoked by uid 500); 17 Mar 2016 21:18:54 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 52965 invoked by uid 500); 17 Mar 2016 21:18:54 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 52954 invoked by uid 99); 17 Mar 2016 21:18:54 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 21:18:54 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E4291DFA0A; Thu, 17 Mar 2016 21:18:53 +0000 (UTC) From: dblotsky To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi... Content-Type: text/plain Message-Id: <20160317211853.E4291DFA0A@git1-us-west.apache.org> Date: Thu, 17 Mar 2016 21:18:53 +0000 (UTC) Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579423 --- Diff: src/android/FileUtils.java --- @@ -73,8 +73,13 @@ Licensed to the Apache Software Foundation (ASF) under one * Permission callback codes */ - public static final int READ_PERM = 0; + public static final int READ_PERM_FILE = 0; public static final int WRITE_PERM = 1; + public static final int READ_PERM_DIR = 2; + public static final int WRITE_PERM_DIR = 3; + public static final int WRITE = 4; + public static final int READ = 5; + public static final int WRITE_PERM_FILE = 6; --- End diff -- The difference between the `WRITE` flag and the `WRITE_PERM`* flags are a bit confusing. Maybe rename `WRITE` to `WRITE_ACTION` and `READ` to `READ_ACTION`? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org