Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: riknoll <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-544-cordova-docs@git.apache.org>
In-Reply-To: <git-pr-544-cordova-docs@git.apache.org>
Subject: [GitHub] cordova-docs pull request: CB-9393: Documenting how to embed
 a Sys...
Content-Type: text/plain
Message-Id: <20160315231133.27625DFA42@git1-us-west.apache.org>
Date: Tue, 15 Mar 2016 23:11:33 +0000 (UTC)

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/544#discussion_r56257204
  
    --- Diff: www/docs/en/dev/guide/platforms/android/webview.md ---
    @@ -29,106 +29,86 @@ components can communicate with each other, see Application Plugins.
     If you're unfamiliar with Android, you should first familiarize
     yourself with the [Android Platform Guide](index.html) and have the latest Android
     SDK installed before you attempt the more unusual development option
    -of embedding a WebView.  Starting with Cordova 1.9, the Android
    -platform relies on a `CordovaWebView` component, which builds on a
    -legacy `CordovaActivity` component that pre-dates the 1.9 release.
    +of embedding a WebView.  Starting with Cordova 4.0, the Android
    +platform relies on a `SystemWebView` component.
     
     1. To follow these instructions, make sure you have the latest Cordova
        distribution. Download it from
        [cordova.apache.org](http://cordova.apache.org) and unzip its
        Android package.
     
    -1. Navigate to the Android package's `/framework` directory and run
    -   `ant jar`. It creates the Cordova `.jar` file, formed as
    -   `/framework/cordova-x.x.x.jar`.
    +1. Create a project in Android Studio
     
    -1. Copy the `.jar` file into the Android project's `/libs` directory.
    +1. Copy the framework directory into your project's root directory and name it
    +CordovaLib
    +
    +1. Add CordovaLib in your settings.gradle file
    +
    +include ':app', ':CordovaLib'
    --- End diff --
    
    This line needs to be indented


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org