Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: nikhilkh <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-160-cordova-windows@git.apache.org>
In-Reply-To: <git-pr-160-cordova-windows@git.apache.org>
Subject: [GitHub] cordova-windows pull request: CB-10831 Apply app description
 to ap...
Content-Type: text/plain
Message-Id: <20160315173020.49360DFA41@git1-us-west.apache.org>
Date: Tue, 15 Mar 2016 17:30:20 +0000 (UTC)

Github user nikhilkh commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/160#discussion_r56205299
  
    --- Diff: template/cordova/lib/prepare.js ---
    @@ -172,6 +172,15 @@ function applyCoreProperties(config, manifest) {
             manifest.getVisualElements().setDisplayName(name);
         }
     
    +    var description = config.description();
    +    manifest.getProperties().setDescription(description);
    +    if (description) {
    --- End diff --
    
    This breaks if say you add a description to config.xml and then remove it - the old description will remain in appxmanifest - we might have to revert back the old description in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org