Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45B0218BC6 for ; Tue, 15 Mar 2016 07:12:35 +0000 (UTC) Received: (qmail 9761 invoked by uid 500); 15 Mar 2016 07:12:34 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 9718 invoked by uid 500); 15 Mar 2016 07:12:34 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 9705 invoked by uid 99); 15 Mar 2016 07:12:34 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Mar 2016 07:12:34 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 77A14DFA43; Tue, 15 Mar 2016 07:12:34 +0000 (UTC) From: vladimir-kotikov To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit... Content-Type: text/plain Message-Id: <20160315071234.77A14DFA43@git1-us-west.apache.org> Date: Tue, 15 Mar 2016 07:12:34 +0000 (UTC) Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/410#discussion_r56122825 --- Diff: cordova-lib/src/cordova/create.js --- @@ -220,8 +220,22 @@ function create(dir, optionalId, optionalName, cfg) { } } }) - .then(function(import_from_path) { - + .then(function(input_directory) { + var import_from_path = input_directory; + var templatePkg; + + //handle package.json present with dirname + if (fs.existsSync(path.join(input_directory,'package.json'))){ --- End diff -- Can we omit this check? If there is no `package.json` in template directory we'll catch this in `catch (e)` below. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org