Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: omefire <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-85-cordova-plugin-media@git.apache.org>
In-Reply-To: <git-pr-85-cordova-plugin-media@git.apache.org>
Subject: [GitHub] cordova-plugin-media pull request: CB-10723: iOS audio
 should use ...
Content-Type: text/plain
Message-Id: <20160309202825.05830DFBD7@git1-us-west.apache.org>
Date: Wed,  9 Mar 2016 20:28:25 +0000 (UTC)

Github user omefire commented on the pull request:

    https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-194492790
  
    This is a base case that was broken. I think it'd be great if you were to add a test case to prevent that from ever happening again. 
    Also, the way the codebase currently is organized, it's so easy to reintroduce this issue again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org