Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: riknoll <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-168-cordova-plugin-file@git.apache.org>
In-Reply-To: <git-pr-168-cordova-plugin-file@git.apache.org>
Subject: [GitHub] cordova-plugin-file pull request: CB-7862: FileReader reads
 large ...
Content-Type: text/plain
Message-Id: <20160308225407.06F51DFBD7@git1-us-west.apache.org>
Date: Tue,  8 Mar 2016 22:54:07 +0000 (UTC)

Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/168#discussion_r55443526
  
    --- Diff: tests/tests.js ---
    @@ -2382,12 +2383,53 @@ exports.defineAutoTests = function () {
                         expect(true).toFailWithMessage('Platform does not supported this feature');
                         done();
                     }
    -                runReaderTest('readAsArrayBuffer', true, done, function (evt, fileData, fileDataAsBinaryString) {
    +                runReaderTest('readAsArrayBuffer', true, done, null, function (evt, fileData, fileDataAsBinaryString) {
                         expect(arrayBufferEqualsString(evt.target.result, fileDataAsBinaryString.slice(0, -1))).toBe(true);
                         done();
                     }, 0, -1);
                 });
    -        });
    +            it("file.spec.94.5 should read large file in multiple chunks, readAsArrayBuffer", function (done) {
    +                // Skip test if ArrayBuffers are not supported (e.g.: Android 2.3).
    +                if (typeof window.ArrayBuffer == 'undefined') {
    +                    expect(true).toFailWithMessage('Platform does not supported this feature');
    --- End diff --
    
    Also, shouldn't this just be pending?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org