Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: jcesarmobile <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-107-cordova-plugin-contacts@git.apache.org>
In-Reply-To: <git-pr-107-cordova-plugin-contacts@git.apache.org>
Subject: [GitHub] cordova-plugin-contacts pull request: CB-10784:
 CDVContactsPicker ...
Content-Type: text/plain
Message-Id: <20160304092340.A67A2E0044@git1-us-west.apache.org>
Date: Fri,  4 Mar 2016 09:23:40 +0000 (UTC)

Github user jcesarmobile commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/107#issuecomment-192202738
  
    LGMT
    
    I think it's not necessary in this case, but maybe you can use a weakSelf, as the current code already uses a lot of this:
    `CDVContacts* __weak weakSelf = self; // play it safe to avoid retain cycles`
    

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org