Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-402-cordova-lib@git.apache.org>
In-Reply-To: <git-pr-402-cordova-lib@git.apache.org>
Subject: [GitHub] cordova-lib pull request: CB-10328 set top-level property of
 plugi...
Content-Type: text/plain
Message-Id: <20160303084408.86861E0B14@git1-us-west.apache.org>
Date: Thu,  3 Mar 2016 08:44:08 +0000 (UTC)

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/402#discussion_r54849930
  
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -71,7 +71,8 @@ module.exports = function installPlugin(platform, project_dir, id, plugins_dir,
         project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
         plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
         options = options || {};
    -    options.is_top_level = true;
    +    if (options.is_top_level === undefined)
    --- End diff --
    
    Maybe use `options.hasOwnProperty`? What if it's set to `null` for example?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org