Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A640F1819E for ; Thu, 3 Mar 2016 08:20:02 +0000 (UTC) Received: (qmail 98337 invoked by uid 500); 3 Mar 2016 08:20:02 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 98296 invoked by uid 500); 3 Mar 2016 08:20:02 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 98285 invoked by uid 99); 3 Mar 2016 08:20:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Mar 2016 08:20:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 04F04E0D58; Thu, 3 Mar 2016 08:20:02 +0000 (UTC) From: ghenry22 To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-plugin-media pull request: CB-10723: iOS audio should use ... Content-Type: text/plain Message-Id: <20160303082002.04F04E0D58@git1-us-west.apache.org> Date: Thu, 3 Mar 2016 08:20:02 +0000 (UTC) Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/85#issuecomment-191648550 The avPlayer.play code is there for playing from remote sources as a stream, it will only be triggered if the source starts with http or https. If the file is local an avPlayer object is not created and avaudioplayer is used through the audiofile object. You can see the play statement for this being triggered in the follow code block underneath this change. This change will break streaming playback from what I can see. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org