Return-Path: 
 <dev-return-56843-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 06D9218E45
	for <apmail-cordova-dev-archive@www.apache.org>;
 Thu,  3 Mar 2016 01:19:25 +0000 (UTC)
Received: (qmail 46216 invoked by uid 500); 3 Mar 2016 01:19:24 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 46175 invoked by uid 500); 3 Mar 2016 01:19:24 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 46163 invoked by uid 99); 3 Mar 2016 01:19:24 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Mar 2016 01:19:24 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 5E68BDFFF8; Thu,  3 Mar 2016 01:19:24 +0000 (UTC)
From: dblotsky <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-528-cordova-docs@git.apache.org>
In-Reply-To: <git-pr-528-cordova-docs@git.apache.org>
Subject: [GitHub] cordova-docs pull request: CB-10178 Fix a number of
 documentation ...
Content-Type: text/plain
Message-Id: <20160303011924.5E68BDFFF8@git1-us-west.apache.org>
Date: Thu,  3 Mar 2016 01:19:24 +0000 (UTC)

Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/528#discussion_r54822846
  
    --- Diff: www/docs/en/dev/config_ref/images.md ---
    @@ -42,79 +45,107 @@ density       | *Optional* <br/> Specified icon density (Android Specific)
     
     The following configuration can be used to define single default icon
     which will be used for all platforms.
    -
    -        <icon src="res/icon.png" />
    -
    +```xml
    +    <icon src="res/icon.png" />
    +```
     For each platform you can also define a pixel-perfect icons set to fit
     different screen resolutions.
     
     ##Android
    -
    -         <platform name="android">
    -                  <icon src="res/android/ldpi.png" density="ldpi" />
    -                  <icon src="res/android/mdpi.png" density="mdpi" />
    -                  <icon src="res/android/hdpi.png" density="hdpi" />
    -                  <icon src="res/android/xhdpi.png" density="xhdpi" />
    -         </platform>
    +```xml
    +    <platform name="android">
    +        <!-- 
    +            ldpi    : 36x36 px
    +            mdpi    : 48x48 px
    +            hdpi    : 72x72 px
    +            xhdpi   : 96x96 px
    +            xxhdpi  : 144x144 px
    +            xxxhdpi : 192x192 px
    +        -->
    +        <icon src="res/android/ldpi.png" density="ldpi" />
    +        <icon src="res/android/mdpi.png" density="mdpi" />
    +        <icon src="res/android/hdpi.png" density="hdpi" />
    +        <icon src="res/android/xhdpi.png" density="xhdpi" />
    +        <icon src="res/android/xxhdpi.png" density="xxhdpi" />
    +        <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
    +    </platform>
    +```
    +###See Also
    +- [Android icon guide](https://www.google.com/design/spec/style/icons.html)
    +- [Android - Supporting multiple screens](http://developer.android.com/guide/practices/screens_support.html)
    --- End diff --
    
    Please use reference-style links.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org