Return-Path: 
 <dev-return-56592-apmail-cordova-dev-archive=cordova.apache.org@cordova.apache.org>
X-Original-To: apmail-cordova-dev-archive@www.apache.org
Delivered-To: apmail-cordova-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id EEA4B19493
	for <apmail-cordova-dev-archive@www.apache.org>;
 Tue,  1 Mar 2016 07:42:37 +0000 (UTC)
Received: (qmail 49345 invoked by uid 500); 1 Mar 2016 07:42:37 -0000
Delivered-To: apmail-cordova-dev-archive@cordova.apache.org
Received: (qmail 49302 invoked by uid 500); 1 Mar 2016 07:42:37 -0000
Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@cordova.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@cordova.apache.org>
List-Post: <mailto:dev@cordova.apache.org>
List-Id: <dev.cordova.apache.org>
Reply-To: dev@cordova.apache.org
Delivered-To: mailing list dev@cordova.apache.org
Received: (qmail 49291 invoked by uid 99); 1 Mar 2016 07:42:37 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Mar 2016 07:42:37 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 2662CDFBA3; Tue,  1 Mar 2016 07:42:37 +0000 (UTC)
From: vladimir-kotikov <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-265-cordova-android@git.apache.org>
In-Reply-To: <git-pr-265-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: CB-10729 Move plugin handlers
 tests ...
Content-Type: text/plain
Message-Id: <20160301074237.2662CDFBA3@git1-us-west.apache.org>
Date: Tue,  1 Mar 2016 07:42:37 +0000 (UTC)

Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/265#discussion_r54531747
  
    --- Diff: bin/templates/cordova/lib/pluginHandlers.js ---
    @@ -31,7 +31,7 @@ var handlers = {
                 if (!obj.src) throw new CordovaError('<source-file> element is missing "src" attribute for plugin: ' + plugin.id);
                 if (!obj.targetDir) throw new CordovaError('<source-file> element is missing "target-dir" attribute for plugin: ' + plugin.id);
                 var dest = path.join(obj.targetDir, path.basename(obj.src));
    -            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, options && options.link);
    +            copyNewFile(plugin.dir, obj.src, project.projectDir, dest, !!(options && options.link));
    --- End diff --
    
    Just some divergence between expected spy arguments and actual ones, Not a bug probably, but i preferred to change parameter type rather than tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org