cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fafaman <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Request audio focus when playin...
Date Thu, 24 Mar 2016 15:01:27 GMT
GitHub user fafaman opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/88

    Request audio focus when playing, pause when focus lost…

    This solves https://issues.apache.org/jira/browse/CB-10951
    
    Request audio focus when playing.
    Pause audio when audio focus is lost.
    Resume playing when audio focus is granted again.
    
    In my opinion, this is closer to the developers expected behaviour and less intrusive
to the user. Also this is closer to the iOS behavior of cordova-plugin-media. Maybe this should
depend on a config.xml setting to accommodate developers using cordova-plugin-media for sound
effects.
    
    Thanks for considering this pull request,  I would be happy to enhance the patch if needed.
    
    Regards,
    Fabrice.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fafaman/cordova-plugin-media android-handle-audio-focus

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #88
    
----
commit 01e80d70fc97cda1c16ad58ddb62ee0f4427effb
Author: Fabrice Lebas <fabrice.lebas@gmail.com>
Date:   2016-03-24T12:28:20Z

    Request audio focus when playing; Pause audio when audio focus is lost; resume playing
when audio focus is granted again.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message