cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-plugin-media-capture pull request: Removing global state a...
Date Sat, 26 Mar 2016 01:07:10 GMT
GitHub user riknoll opened a pull request:

    Removing global state and fixing CB-10670

    There are two parts to this PR.
    The first is to fix Marshmallow permissions (CB-10670). `captureImage()` was not requesting
`READ_EXTERNAL_STORAGE` and both `captureImage()` and `captureVideo()` needed the fix that
was recently done in the camera plugin for the `CAMERA` permission (
    The second was to remove the global state being maintained in the plugin. This caused
a lot of issues when async calls to the plugin overlap. It is included in this PR because
most of them are related to async Android calls like requesting permissions and launching
external Activities (see also I'm planning
on doing a similar fix for the file plugin soon.

You can merge this pull request into a Git repository by running:

    $ git pull CB-10670refactor

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #59
commit 3f1e3366daf2fe9cb4c4195468a27eee5714bd98
Author: Richard Knoll <>
Date:   2016-03-21T22:21:30Z

    CB-10670 android: Fixing Marshmallow permissions for image and video capture

commit 6511db0af87806ad32abdcacfcb78619c60a8d6d
Author: Richard Knoll <>
Date:   2016-03-23T18:28:58Z

    Refactor and fixing support for multiple Activity Requests

commit df0f9a66ac9393745d8d9dad927548504368c725
Author: Richard Knoll <>
Date:   2016-03-26T00:51:01Z

    Documenting capture error


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message