cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ktop <...@git.apache.org>
Subject [GitHub] cordova-android pull request: CB-10897 Refactor URI Parsing for Wh...
Date Fri, 18 Mar 2016 19:28:03 GMT
GitHub user ktop opened a pull request:

    https://github.com/apache/cordova-android/pull/283

    CB-10897 Refactor URI Parsing for Whitelist

    Fix for CB-10897. 
    
    I moved out the code that parses the 'origin' from the whitelist to a separate function
so that it can also be used to parse the URLs that request access instead of using Android's
Uri class parse function. Android's Uri parse function does not parse 'host' the same way
that Cordova parses the host in origin for whitelist, so host ends up being null and the comparison
fails. Using the same parsing methods is the way to go to give accurate comparisons of URLs
to those in the whitelist. 
    
    Also, I can have specific non http/https URLs in my whitelist now. 
    Something like this works now without the wildcard:
    <allow-intent href="market://details?id=com.google.android.apps.maps" />

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ktop/cordova-android CB-10897

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #283
    
----
commit 26662acada6f44a83c11c1e13faa8fea3a959720
Author: Karen Tran <ktop500@gmail.com>
Date:   2016-03-18T18:45:57Z

    CB-10897 Refactor URI Parsing for Whitelist

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message