cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From oratthumzap <...@git.apache.org>
Subject [GitHub] cordova-android pull request: fullscreen no immersive
Date Thu, 17 Mar 2016 08:32:22 GMT
GitHub user oratthumzap opened a pull request:

    https://github.com/apache/cordova-android/pull/279

    fullscreen no immersive

    hi,
    we are using Cordova and would like to have the ability to set the Cordova activity in
full screen mode, and not in an immersive mode regardless of the Android version (as was the
case in previous Cordova versions).
    therefore, we added a new configuration key to the Cordova config: "FullscreenNotImmersive".
    when set to true the Cordova activity will be started using the full-screen-not-immersive
flags.
    otherwise, it will be started using the relevant flags according to the Android version
(the original v5.1.x implementation). by default, this configuration key is set to false (=
original implementation).
    we would appreciate if you could merge this pull request so that other developers would
be able to enjoy this logic ;)
    
    @infil00p @daserge - i closed the previous pull request, and created a new one under master
as you requested ;)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thumzap/cordova-android master-fullscreen-no-immersive

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/279.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #279
    
----
commit a1ababb06b12e3300f1693262975fee75f4c25e1
Author: Or Arnon <or@thumzap.com>
Date:   2016-03-17T08:29:43Z

    added ability for cordova activity to be viewed in a real full screen regardless of android
version (as was the case in previous cordova versions)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message