cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpolivy <...@git.apache.org>
Subject [GitHub] cordova-android pull request: [CB-10600] 'cordova run --release' u...
Date Thu, 10 Mar 2016 18:06:26 GMT
GitHub user dpolivy opened a pull request:

    https://github.com/apache/cordova-android/pull/273

    [CB-10600] 'cordova run --release' uses wrong apk

    When doing `cordova run android --release`, the CLI attempts to use the
    android-release-unsigned.apk, which naturally fails to install on the
    device because it is unsigned. The release build does also generate the
    properly signed android-release.apk, and that should be used instead.
    
    The apk-finding logic for "debug" excludes unsigned builds, so the
    "release" logic should follow a similar pattern.
    
    Fixes https://issues.apache.org/jira/browse/CB-10600

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpolivy/cordova-android CB10600

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/273.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #273
    
----
commit c788355ab1cb6234441166bbc92ca7b5c6c4c52b
Author: Dan Polivy <dan@cellartracker.com>
Date:   2016-03-10T18:05:52Z

    [CB-10600] 'cordova run --release' uses wrong apk
    
    When doing `cordova run android --release`, the CLI attempts to use the
    android-release-unsigned.apk, which naturally fails to install on the
    device because it is unsigned. The release build does also generate the
    properly signed android-release.apk, and that should be used instead.
    
    The apk-finding logic for "debug" excludes unsigned builds, so the
    "release" logic should follow a similar pattern.
    
    Fixes https://issues.apache.org/jira/browse/CB-10600

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message