cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mehmetcodes <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Update plugin.xml
Date Tue, 29 Mar 2016 15:57:26 GMT
GitHub user mehmetcodes opened a pull request:

    https://github.com/apache/cordova-plugin-camera/pull/199

    Update plugin.xml

    In principle Cordova should not use a permission where it is no longer relevant as it
might leave things less secure.
    
    You can see this documentation here http://developer.android.com/guide/topics/manifest/uses-permission-element.html
    
    Note the following in the documentation:
    
    ============================================================================================
    android:maxSdkVersion
    The highest API level at which this permission should be granted to your app. Setting
this attribute is useful if the permission your app requires is no longer needed beginning
at a certain API level.
    For example, beginning with Android 4.4 (API level 19), it's no longer necessary for your
app to request the WRITE_EXTERNAL_STORAGE permission when your app wants to write to its own
application-specific directories on external storage (the directories provided by getExternalFilesDir()).
However, the permission is required for API level 18 and lower. So you can declare that this
permission is needed only up to API level 18 with a declaration such as this:
    
    <uses-permission
         android:name="android.permission.WRITE_EXTERNAL_STORAGE"
         android:maxSdkVersion="18" />
    This way, beginning with API level 19, the system will no longer grant your app the WRITE_EXTERNAL_STORAGE
permission.
    
    This attribute was added in API level 19.
    ==============================================================================================

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mehmetcodes/cordova-plugin-camera patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-camera/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit f20d1d5c8f59766bdb67ec2e25d7dacf19cbd91c
Author: mehmetcodes <mehmetcodes@gmail.com>
Date:   2016-03-29T15:56:43Z

    Update plugin.xml
    
    In principle Cordova should not use a permission where it is no longer relevant as it
might leave things less secure.
    
    You can see this documentation here http://developer.android.com/guide/topics/manifest/uses-permission-element.html
    
    Note the following in the documentation:
    
    ============================================================================================
    android:maxSdkVersion
    The highest API level at which this permission should be granted to your app. Setting
this attribute is useful if the permission your app requires is no longer needed beginning
at a certain API level.
    For example, beginning with Android 4.4 (API level 19), it's no longer necessary for your
app to request the WRITE_EXTERNAL_STORAGE permission when your app wants to write to its own
application-specific directories on external storage (the directories provided by getExternalFilesDir()).
However, the permission is required for API level 18 and lower. So you can declare that this
permission is needed only up to API level 18 with a declaration such as this:
    
    <uses-permission
         android:name="android.permission.WRITE_EXTERNAL_STORAGE"
         android:maxSdkVersion="18" />
    This way, beginning with API level 19, the system will no longer grant your app the WRITE_EXTERNAL_STORAGE
permission.
    
    This attribute was added in API level 19.
    ==============================================================================================

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message