cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-plugin-camera pull request: CB-10825 android: Always reque...
Date Wed, 09 Mar 2016 20:24:46 GMT
GitHub user riknoll opened a pull request:

    CB-10825 android: Always request READ permission for gallery source

    I am unhappy with this change, but this issue is blocking a release and a proper fix could
end up being a major rewrite to how we do permissions. The issue at the center of this is
that whether or not we need the READ permission changes according to the camera options passed
to `getPicture()` and the app used to select a photo. We need to fix how we request permissions
so that we request them *after* the photo is selected, and only when we need them. 
    Really, the bigger issue is that we try and convert all `content://` URIs into real file
paths. As I understand it, Content resolvers are not intended for that purpose.

You can merge this pull request into a Git repository by running:

    $ git pull CB-10825

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #191
commit ff90cc2c5d1e9ea3f69898a7ddf4678373fec07a
Author: Richard Knoll <>
Date:   2016-03-09T20:09:09Z

    CB-10825 android: Always request READ permission for gallery source


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message