cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...
Date Fri, 11 Mar 2016 19:11:31 GMT
GitHub user rakatyal opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/170

    CB-10798, CB-10384: Fixing permissions for Marshmallow

    The present code used to ask for permissions on Marshmallow while even trying to read/write
from the application's own locations. It should only ask for permission while trying to write
to external locations. Also, the getDirectory method currently didn't include permission check
which caused it to break while trying to create a directory in an external location. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-plugin-file raghav-permissions

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/170.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #170
    
----
commit 2b4d95abfc7131a6cb2eca431dc0f4747466e27d
Author: Raghav Katyal <rakatyal@microsoft.com>
Date:   2016-03-11T19:03:30Z

    CB-10798, CB-10384: Fixing permissions for Marshmallow

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message