cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jasongin <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-10577: Windows resolveLocalFi...
Date Wed, 09 Mar 2016 18:02:24 GMT
GitHub user jasongin opened a pull request:

    https://github.com/apache/cordova-plugin-file/pull/169

    CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for file

    The FileEntry constructor should remove any trailing slash from its path. This parallels
the existing DirectoryEntry constructor code which adds a trailing slash if missing.
    
    This is actually not a Windows-specific fix, but it fixes a file plugin test case failure
that was observed on Windows after I recently added that test case to validate an Android
fix. Windows already invokes the correct FileEntry/DirEntry constructor based on the actual
file/directory status of the path, so fixing the trailing slash is all that is needed.
    
    @riknoll or @rakatyal please review

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasongin/cordova-plugin-file CB-10577a

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #169
    
----
commit 2132bbf2d8bd1d45f500270b64f348f8ba001b75
Author: Jason Ginchereau <jasongin@microsoft.com>
Date:   2016-03-09T17:54:44Z

    CB-10577: Windows resolveLocalFileSystemURL should omit trailing slash for file

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message