cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ATGardner <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: send back loaderror when...
Date Mon, 21 Mar 2016 09:40:30 GMT
GitHub user ATGardner opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/156

    send back loaderror when "show" fails.

    I noticed that when I try to open "_system", it silently fails, but returns the error
message as a result. In the js code, that error doesn't end up calling any event listeners
on the iab object.
    I removed the useless "sendPluginResult" when the result is an empty string, and called
the "loaderror" event on failure (when the result is not empty)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ATGardner/cordova-plugin-inappbrowser master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #156
    
----
commit 5e59fd7bf473280fa8e66e763ecb58d9c387a8dc
Author: Noam Gal <noamg@harmon.ie>
Date:   2016-03-21T09:33:43Z

    send back loaderror when "show" fails.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message