cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sarangan12 <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: Fix for the specs 26&27 to u...
Date Thu, 31 Mar 2016 01:27:41 GMT
GitHub user sarangan12 opened a pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/112

    Fix for the specs 26&27 to use the newly created contacts for removal test

    The newly created contact is not used for deletion. The removal logic still holds the
reference to the older value and uses it. So, changed the logic to use the passed in parameter.

    
    Both specs 26&27 were consistently failing before this changes. Now they are passing.
    
    @riknoll  @omefire @nikhilkh @rakatyal  Can you please review and merge this PR?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sarangan12/cordova-plugin-contacts flakytests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-contacts/pull/112.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #112
    
----
commit 8e6849cd1807be903e47491bdb21ea813174869d
Author: Sarangan Rajamanickam <sarajama@microsoft.com>
Date:   2016-03-31T01:23:46Z

    Fix for the specs 26&27 to use the newly created contacts for removal test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message