cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikhil Khandelwal <nikhi...@microsoft.com>
Subject RE: [ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global preferences
Date Wed, 16 Mar 2016 18:13:43 GMT
Thanks for the heads up. Good find! (1) sounds pretty bad - correct me if I'm wrong, to fix
this, we need to do the following:
- fix it in cordova-common, release
- bundle those changes to all platforms & release all of them.

We need tests for this scenario also.

Shaz: Are you planning to take all the tasks above? Some of us could likely help.

-Nikhil

-----Original Message-----
From: Shazron [mailto:shazron@gmail.com] 
Sent: Wednesday, March 16, 2016 10:32 AM
To: dev@cordova.apache.org
Subject: [ALL PLATFORMS][cordova-common] Platform specific preferences overridden by global
preferences

Some code changes I want to highlight that I want changing, in cordova-common:

1. https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-10694&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=ynROJ1IjgLWqIcLk9AYH9%2fzlQTn%2fbVooUcyWk5iG12Q%3d

Platform specific preferences are "overriden" by global preferences, because when the merged
config.xml file (root config.xml merge with platform config.xml), the global preferences are
written last always, so they clobber any previous declaration. The change is to write platform
preferences last:

https://github.com/apache/cordova-lib/blob/a3285602b88f4e40f08c178b8b26c918c91d0dce/cordova-common/src/util/xml-helpers.js#L212-L217

2. https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues.apache.org%2fjira%2fbrowse%2fCB-9264&data=01%7c01%7cnikhilkh%40microsoft.com%7c2393d3eed1794bcda84b08d34dc10912%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uKrVMPdcY2zBnYiGrTASEoKAlGoanmcdd6ME0BIlPd4%3d

This is not as critical as #1 above, since it's just a build artifact thing.This is just to
remove duplicate entries in the merged config.xml.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Mime
View raw message