cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: Fix for the specs 26&27 to u...
Date Thu, 31 Mar 2016 17:18:09 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/112#discussion_r58091953
  
    --- Diff: tests/tests.js ---
    @@ -589,10 +589,8 @@ exports.defineAutoTests = function() {
                     removeContactsByFields(["note"], "DeleteMe", function() {
                         contact.save(function(c_obj) {
                             var findWin = function(cs) {
    -                            // update to have proper saved id
    -                            contact = cs[0];
                                 expect(cs.length).toBe(1);
    -                            done();
    +                            done(cs[0]);
    --- End diff --
    
    The docs don't say anything about it (but the Jasmine docs are also pretty lackluster).
My guess is that the parameter would just get ignored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message