cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dubeejw <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Date Wed, 30 Mar 2016 15:11:11 GMT
Github user dubeejw commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57905311
  
    --- Diff: template/cordova/lib/PluginHandler.js ---
    @@ -85,12 +85,12 @@ var handlers = {
                 var src = obj.src;
                 var dest = src;
                 var type = obj.type;
    +            var targetDir = obj.targetDir || '';
    --- End diff --
    
    JavaScript will by default "hoist" variables to the top of functions, which I why I didn't
place the variable in the else block.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message