cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-plugin-splashscreen pull request: Added new spinner style,...
Date Wed, 30 Mar 2016 13:03:37 GMT
Github user jcesarmobile commented on the pull request:

    https://github.com/apache/cordova-plugin-splashscreen/pull/95#issuecomment-203421921
  
    Thanks for this PB, but I think we should keep plugins simple and this PR add too many
features and they are iOS only.
    
    Why does it need the HTML5 Boilerplate license?
    
    I think the material spinner and the listener for the frame URL reloads should be separated
plugins, not part of the splashscreen plugin.
    
    For the iPad pro and other bug fixes. Do they have a JIRA issue? if not, it should be
created and use the id on the title of the PR. (http://issues.cordova.io/)
    For the new iPad pro splash you add, can you add it to the README.md Example Configuration
section too? We should create an iPad pro default splash too and add it to the base project.
    
    What is the window.nativeWrapper clobber for?
    
    Before we can merge it though, you need to sign Apache's Contributor License Agreement
(can be done online): http://www.apache.org/licenses/#clas
    
    Not sure if Goff Marocchi, Gabriela Pittari and James Clement have to sign theirs too.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message