cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From alsorokin <...@git.apache.org>
Subject [GitHub] cordova-medic pull request: Appium runner improvements
Date Wed, 30 Mar 2016 09:46:25 GMT
Github user alsorokin commented on a diff in the pull request:

    https://github.com/apache/cordova-medic/pull/85#discussion_r57862046
  
    --- Diff: medic/medic-appium.js ---
    @@ -197,9 +214,10 @@ function parseArgs() {
         return options;
     }
     
    -function getLocalCLI() {
    -    if (util.isWindows()) {
    -        return "cordova.bat";
    +function getLocalCLI(appPath) {
    +    if (util.isWindows() || !fs.existsSync(path.join(getFullAppPath(appPath), "./cordova")))
{
    --- End diff --
    
    Windows doesn't need the dot-slash to execute this .bat
    So basically, on windows "cordova" command would execute .bat and if it's not there, will
execute global cordova.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message