cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Date Tue, 29 Mar 2016 20:52:13 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57798321
  
    --- Diff: spec/unit/pluginHandler/windows.spec.js ---
    @@ -441,40 +451,47 @@ describe('windows project handler', function () {
                 });
             });
     
    -        describe('of <framework> elements', function () {
    +       describe('of <framework> elements', function () {
                 // This could be separated into individual specs, but that results in a lot
of copying and deleting the
                 // project files, which is not needed.
                 it('should remove from correct project files when conditions specified',
function () {
    +                var curDir;
    +                curDir = __dirname;
    +                process.chdir(path.join(curDir, '..', 'fixtures', 'testProj'));
    +
                     var frameworks = copyArray(valid_frameworks);
     
                     frameworks.forEach(function(framework) {
                         PluginHandler.getInstaller('framework')(framework, dummyPluginInfo,
dummyProject);
                     });
     
    -                var path = 'ItemGroup/Reference';
    --- End diff --
    
    Is there a need to rename this to path2?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message