cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-10927 - Framework references in p...
Date Tue, 29 Mar 2016 20:47:19 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/163#discussion_r57797472
  
    --- Diff: spec/unit/pluginHandler/windows.spec.js ---
    @@ -305,17 +306,25 @@ describe('windows project handler', function () {
                 var frameworks = copyArray(valid_frameworks);
     
                 it('should write to correct project files when conditions are specified',
function () {
    -                var xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src',
'windows', 'dummy1.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x64\'"]';
    +                var curDir;
    +                var xpath;
    +
    +                curDir = __dirname;
    +                process.chdir(path.join(curDir, '..', 'fixtures', 'testProj'));
    +
    +                xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins',
'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy1.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x64\'"]';
                     validateInstalledProjects('framework', frameworks[6], xpath, ['all']);
     
    -                xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows',
'dummy2.vcxproj') + '"]';
    +                xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins',
'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy2.vcxproj') + '"]';
                     validateInstalledProjects('framework', frameworks[7], xpath, ['windows8']);
     
    -                xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows',
'dummy3.vcxproj') + '"]';
    +                xpath = 'ProjectReference[@Include="' + winJoin('..', '..', 'plugins',
'org.test.plugins.dummyplugin', 'src', 'windows', 'dummy3.vcxproj') + '"]';
                     validateInstalledProjects('framework', frameworks[8], xpath, ['windows',
'windows8', 'windows10']);
     
    -                xpath = 'ProjectReference[@Include="' + winJoin(dummyplugin, 'src', 'windows',
'dummy4.vcxproj') + '"][@Condition="\'$(Platform)\'==\'x86\'"]';
    --- End diff --
    
    Don't we need this condition anymore?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message