cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...
Date Tue, 29 Mar 2016 06:25:51 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/418#discussion_r57676830
  
    --- Diff: cordova-common/spec/events.spec.js ---
    @@ -0,0 +1,30 @@
    +/**
    +    Licensed to the Apache Software Foundation (ASF) under one
    +    or more contributor license agreements.  See the NOTICE file
    +    distributed with this work for additional information
    +    regarding copyright ownership.  The ASF licenses this file
    +    to you under the Apache License, Version 2.0 (the
    +    "License"); you may not use this file except in compliance
    +    with the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +    Unless required by applicable law or agreed to in writing,
    +    software distributed under the License is distributed on an
    +    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +    KIND, either express or implied.  See the License for the
    +    specific language governing permissions and limitations
    +    under the License.
    +*/
    +
    +var events = require('../src/events');
    +
    +describe('forwardEventsTo method', function () {
    +    afterEach(function() {
    +        events.forwardEventsTo(null);
    +    });
    +    it('should not go to infinite loop when trying to forward to self', function () {
    +        events.forwardEventsTo(events);
    +        events.emit('log', 'test message');
    --- End diff --
    
    > This test will fail if we go into an infinite recursion as the title says. 
    
    You mean that this will be caught by Jasmine and reported as failure? Then it makes sense,
please add a comment clarifying this.
    
    > to verify that forwarding has been reset after events.forwardEventsTo(events) call
    
    Nice. Let's do it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message