cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From daserge <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...
Date Tue, 29 Mar 2016 05:31:57 GMT
Github user daserge commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/418#discussion_r57673594
  
    --- Diff: cordova-common/src/events.js ---
    @@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) {
         if (!(eventEmitter instanceof EventEmitter))
             throw new Error('Cordova events could be redirected to another EventEmitter instance
only');
     
    -    EVENTS_RECEIVER = eventEmitter;
    +    // Skipping forwarding to self to avoid infinite recursion.
    +    // This is the case when the modules are npm-linked.
    +    if(this !== eventEmitter) {
    --- End diff --
    
    Yeah, probably you are right, I'll update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message