cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-10940 Can't add Android platform from...
Date Mon, 28 Mar 2016 20:58:53 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-common/src/events.js ---
    @@ -42,7 +42,11 @@ module.exports.forwardEventsTo = function (eventEmitter) {
         if (!(eventEmitter instanceof EventEmitter))
             throw new Error('Cordova events could be redirected to another EventEmitter instance
    -    EVENTS_RECEIVER = eventEmitter;
    +    // Skipping forwarding to self to avoid infinite recursion.
    +    // This is the case when the modules are npm-linked.
    +    if(this !== eventEmitter) {
    --- End diff --
    nit: please add space after `if`. Also could you please reference JIRA here so it'd be
more clear why we're checking this

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message