cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paulhickman-a365 <...@git.apache.org>
Subject [GitHub] cordova-plugin-file-transfer pull request: CB-10771: Fixing failur...
Date Sun, 27 Mar 2016 12:34:41 GMT
Github user paulhickman-a365 commented on the pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/133#issuecomment-202054865
  
    Won't using "params[key]" as the test make it also ignore non-string values such as 0
or boolean false? Testing for undefined, null and "" explicitly would be better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message