cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Date Sat, 26 Mar 2016 21:58:28 GMT
Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-lib/pull/416#issuecomment-201937380
  
    @vladimir-kotikov  yes lets fix this in cordova-lib to get a fix in CLI 6.1.1, but I agree
with you that problem should also be fix in iOS 
    
    The root of the problem is the merge of XML the <name> value from project config.xml
doesn't overwrite the <name> in default platform config.xml <name> I open the
JIRA [CB-10965](https://issues.apache.org/jira/browse/CB-10965)
    The real problem is cordova-common merge util where i think the tag name should be single
instance in result of merge https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/xml-helpers.js#L197
    similar as author and description.
    it will require a cordova-common release, then an iOS to pick up the change. But I think
fixing in CLI 6.1.1  is required to not brake other ios platforms versions that don't have
this fix 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message