cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10961 Error when adding ios platform ...
Date Sat, 26 Mar 2016 21:05:47 GMT
Github user vladimir-kotikov commented on the pull request:

    https://github.com/apache/cordova-lib/pull/416#issuecomment-201929790
  
    @csantanapr, this LGTM and i believe it would solve the problem, but I think the real
problem is in cordova-ios `prepare` method - when you change app's name this change doesn't
reflected to ios `Api`'s properties (see [prepare.js#L189-L191](https://github.com/apache/cordova-ios/blob/master/bin/templates/scripts/cordova/lib/prepare.js#L189-L191)),
and when you call `Api` next time, it uses the old project's path.
    
    It looks like https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db
that you mentioned just uncovered the real problem.
    
    If you think this is urgent, we could merge this and do 6.1.1 release but i'd like to
fix this in iOS instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message