cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From swbradshaw <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-4078: correctOrientation no...
Date Sat, 26 Mar 2016 00:23:29 GMT
Github user swbradshaw commented on the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/197#issuecomment-201611674
  
    @riknoll - I found the changes you were talking about. The changes in CB-10460 will make
the `ouputModifiedBitmap()` function correctly because the FileHelper will now return null,
which is what it was expecting.  There are no further changes on my side needed. With this
change and CB-10460 combined, I can now pick photos from any Document Provider (Drive, Gallery,
Photos, QuickPic) and it will successfully correct the orientation and resize the photo.
    
    One suggestion I have is to rename CB-10460 to something like "Choosing pictures from
3rd party provider (Gallery, Photo, Drive) will result in error".   If the current title is
published on the blog, users aren't going to know what "getRealPath return null in some cases"
means. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message