cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcesarmobile <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-10942 - Cannot <allow-navigation href...
Date Thu, 24 Mar 2016 09:46:40 GMT
Github user jcesarmobile commented on the pull request:

    https://github.com/apache/cordova-ios/pull/211#issuecomment-200759257
  
    Tested and working fine
    
    I think the first if can be removed
    ```
    if (allowNavigationsPass && allowIntentPass) {
        return CDVIntentAndNavigationFilterValueNavigationAllowed;
    }``` 
    
    This one is enough
    ```
    if (allowNavigationsPass) {
        return CDVIntentAndNavigationFilterValueNavigationAllowed;
    }```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message