cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: Making focus handlers to only ...
Date Wed, 23 Mar 2016 23:03:43 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/196#discussion_r57252153
  
    --- Diff: src/windows/CameraProxy.js ---
    @@ -758,16 +759,31 @@ function takePictureFromCameraWindows(successCallback, errorCallback,
args) {
             }, successCallback, errorCallback);
         };
     
    -    // add and delete focus eventHandler to capture the focus back from cameraUI to app

    -    window.addEventListener("focus", savePhotoOnFocus);
    -    cameraCaptureUI.captureFileAsync(WMCapture.CameraCaptureUIMode.photo).done(function(picture)
{
    +    // if windows phone 10, add and delete focus eventHandler to capture the focus back
from cameraUI to app
    +    if (navigator.appVersion.indexOf('Windows Phone 10.0') >= 0) { 
    --- End diff --
    
    I think this is our best option. Also the other checks in this file seems to use this
property as well. It would break when the version changes though yes. 
    Non phone windows 10 works fine without the focus handler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message