cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rakatyal <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...
Date Fri, 18 Mar 2016 02:38:15 GMT
Github user rakatyal commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56607030
  
    --- Diff: src/android/FileUtils.java ---
    @@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws FileExistsException, IOException,
TypeMis
                         }
                     }, lastRawArgs, callback);
                     break;
    -            case WRITE_PERM:
    +            case PERM_DIR:
    +                threadhelper( new FileOp( ){
    +                    public void run(JSONArray args) throws FileExistsException, IOException,
TypeMismatchException, EncodingException, JSONException {
    +                        String dirname = args.getString(0);
    +
    +                        String path = args.getString(1);
    +                        JSONObject obj = getFile(dirname, path, args.optJSONObject(2),
true);
    +                        callback.success(obj);
    +                    }
    +                }, lastRawArgs, callback);
    +                break;    
    +            case WRITE_ACTION:
    --- End diff --
    
    I like this convention better since this differentiates the calls for 'FILE' and 'DIR'.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message