cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-10798, CB-10384: Fixing permi...
Date Thu, 17 Mar 2016 21:18:53 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579423
  
    --- Diff: src/android/FileUtils.java ---
    @@ -73,8 +73,13 @@ Licensed to the Apache Software Foundation (ASF) under one
          * Permission callback codes
          */
     
    -    public static final int READ_PERM = 0;
    +    public static final int READ_PERM_FILE = 0;
         public static final int WRITE_PERM = 1;
    +    public static final int READ_PERM_DIR = 2;
    +    public static final int WRITE_PERM_DIR = 3;
    +    public static final int WRITE = 4;
    +    public static final int READ = 5;
    +    public static final int WRITE_PERM_FILE = 6;
    --- End diff --
    
    The difference between the `WRITE` flag and the `WRITE_PERM`* flags are a bit confusing.
Maybe rename `WRITE` to `WRITE_ACTION` and `READ` to `READ_ACTION`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message