cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <>
Subject [GitHub] cordova-plugin-media-capture pull request: [CB-10554] Fix null ref...
Date Wed, 16 Mar 2016 21:05:17 GMT
Github user riknoll commented on the pull request:
    @adamduren  I've tested this and the save/restore stuff appears to work great! There is
an issue, however, with the results that are returned in the resume event. They need to be
wrapped in `MediaFile` objects before use. This was also an issue in the Contacts plugin where
they needed to be wrapped in a `Contact` object and the solution was to just provide an example
of how to do that in the README (see [here](
In this plugin it is a little bit trickier because we need to decide how to expose the `MediaFile`
object creation. Currently, it just happens in the `exec` callback [here](
without a public API. Thoughts? Maybe we should add a `MediaFile` constructor that encapsulates
that `exec` callback? That at least would not be a breaking change.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message