cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-10399 Added Appium tests
Date Wed, 16 Mar 2016 17:31:56 GMT
Github user dblotsky commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197445134
  
    @sgrebnov `fn.toString` is also a pretty nasty pattern. Adding buttons for manual tests
is literally what manual tests are. We control both the tests and the UI. Why is that a bad
thing? This is one of those cases where applying the DRY (Don't Repeat Yourself) principle
doesn't make things much better and makes the code a lot harder to maintain. Just modify the
test app. That way we can also test it manually without Appium.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message