cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dblotsky <...@git.apache.org>
Subject [GitHub] cordova-plugin-camera pull request: CB-10865 Run ios native tests ...
Date Wed, 16 Mar 2016 16:54:17 GMT
Github user dblotsky commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-camera/pull/195#discussion_r56371109
  
    --- Diff: tests/ios/CDVCameraTest/CDVCameraLibTests/CameraTest.m ---
    @@ -304,24 +303,28 @@ - (void) testImageScaleNoCropForSize {
         
         // test 800x600
         
    -    targetSize = CGSizeMake(800, 600);
    +    targetSize = CGSizeMake(600, 800);
         
         targetImage = [sourceImagePortrait imageByScalingNotCroppingForSize:targetSize];
         XCTAssertEqual(targetImage.size.width, targetSize.width);
         XCTAssertEqual(targetImage.size.height, targetSize.height);
         
    +    targetSize = CGSizeMake(800, 600);
    +
         targetImage = [sourceImageLandscape imageByScalingNotCroppingForSize:targetSize];
         XCTAssertEqual(targetImage.size.width, targetSize.width);
         XCTAssertEqual(targetImage.size.height, targetSize.height);
         
         // test 1024x768
         
    -    targetSize = CGSizeMake(1024, 768);
    +    targetSize = CGSizeMake(768, 1024);
         
         targetImage = [sourceImagePortrait imageByScalingNotCroppingForSize:targetSize];
         XCTAssertEqual(targetImage.size.width, targetSize.width);
         XCTAssertEqual(targetImage.size.height, targetSize.height);
         
    +    targetSize = CGSizeMake(1024, 768);
    +
    --- End diff --
    
    It might make life easier to put these guys in a loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message