cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ChickenMythic <...@git.apache.org>
Subject [GitHub] cordova-weinre pull request: Support IE Mobile
Date Wed, 16 Mar 2016 08:11:56 GMT
Github user ChickenMythic commented on the pull request:

    https://github.com/apache/cordova-weinre/pull/14#issuecomment-197206256
  
    There is no issue opened for this at Jira, you create one if you want to, I won't do it.
    
    Here is the issue description:
    We've used weinre library and the code is executed in webview on various mobile platforms
(iOS, Android and WindowsPhone). It works fine on iOS and Android but not on WindowsPhone
as IE (11) does not support overriding of standard storage functions.
    All values set as storage properties are cast to String. As a result, localStorage getItem,
setItem and removeItem functions are no more functions and thus, we can no longer use localStorage
once weinre got initialized.
    By digging into our code, it led us to weinre library code, then we found it came from
this line un "_weinre.web/modules/weinre/common/HookLib.coffee_".
    The test originally made to avoid this issue on IE was made for the Desktop version of
IE but did not take the Mobile version into account that's why I just suggested to add "IEMobile"
to this condition.
    
    WindowsPhone uses a slightly different version of IE 11.
    
    
    Let me know if you think this fix is appropriate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message