cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-10808 CLI Should handle templates wit...
Date Tue, 15 Mar 2016 21:47:45 GMT
Github user stevengill commented on the pull request:

    https://github.com/apache/cordova-lib/pull/410#issuecomment-197038950
  
    I don't think you should be running npm install carlos. This code doesn't even check if
npm exists before trying to run it. 
    
    I recommend you leaving the npm install to the fetch refactor (https://github.com/cordova/cordova-discuss/pull/33).
    
    I'm not sure about this PR. I know you merged it in already. I think it requires more
discussion. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message