cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: CB-10840 Use cordova-common.CordovaLogge...
Date Mon, 14 Mar 2016 08:44:29 GMT
Github user vladimir-kotikov commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/205#discussion_r55968611
  
    --- Diff: bin/templates/scripts/cordova/Api.js ---
    @@ -202,7 +217,7 @@ Api.prototype.addPlugin = function (plugin, installOptions) {
      */
     Api.prototype.removePlugin = function (plugin, uninstallOptions) {
         var Plugman = require('./lib/plugman/Plugman');
    -    return Plugman.get(this.locations, this.events).removePlugin(plugin, uninstallOptions);
    +    return Plugman.get(this.locations, events).removePlugin(plugin, uninstallOptions);
    --- End diff --
    
    Looks like `Plugman` doesn't use `events` parameter. Can we just remove it here and in
`Plugman`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message