cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From riknoll <...@git.apache.org>
Subject [GitHub] cordova-docs pull request: Fix syntax highlighting within the Andr...
Date Thu, 10 Mar 2016 18:24:28 GMT
Github user riknoll commented on a diff in the pull request:

    https://github.com/apache/cordova-docs/pull/549#discussion_r55724956
  
    --- Diff: www/docs/en/dev/guide/platforms/android/plugin.md ---
    @@ -284,72 +302,87 @@ documentation [here][permissions-guide].
     
     As far as a plugin is concerned, the permission can be requested by calling the permission
method, which signature is as follows:
     
    -        cordova.requestPermission(CordovaPlugin plugin, int requestCode, String permission);
    +```java
    +cordova.requestPermission(CordovaPlugin plugin, int requestCode, String permission);
    +```
     
     To cut down on verbosity, it's standard practice to assign this to a local static variable:
     
    -    public static final String READ = Manifest.permission.READ_CONTACTS;
    +```
    --- End diff --
    
    Why not tag these as Java?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message