cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nikhilkh <>
Subject [GitHub] cordova-lib pull request: CB-9858 Cordova Fetch Work
Date Wed, 09 Mar 2016 05:14:18 GMT
Github user nikhilkh commented on a diff in the pull request:
    --- Diff: cordova-fetch/index.js ---
    @@ -0,0 +1,176 @@
    + Licensed to the Apache Software Foundation (ASF) under one
    + or more contributor license agreements.  See the NOTICE file
    + distributed with this work for additional information
    + regarding copyright ownership.  The ASF licenses this file
    + to you under the Apache License, Version 2.0 (the
    + 'License'); you may not use this file except in compliance
    + with the License.  You may obtain a copy of the License at
    + Unless required by applicable law or agreed to in writing,
    + software distributed under the License is distributed on an
    + KIND, either express or implied.  See the License for the
    + specific language governing permissions and limitations
    + under the License.
    + */
    +var Q = require('q');
    +var shell = require('shelljs');
    +var superspawn = require('cordova-common').superspawn;
    +var events = require('cordova-common').events;
    +var depls = require('dependency-ls');
    +var path = require('path');
    +var fs = require('fs');
    +var CordovaError = require('cordova-common').CordovaError;
    +var isUrl = require('is-url');
    + * A module that npm installs a module from npm or a git url
    + *
    + * @param {String} target   the packageID or git url
    + * @param {String} dest     destination of where to install the module
    + * @param {Object} opts     [opts={save:true}] options to pass to fetch module
    + *
    + * @return {String||Promise}    Returns string of the absolute path to the installed
    + *
    + */
    +module.exports = function(target, dest, opts) {
    +    var fetchArgs = ['install'];
    +    opts = opts || {};
    +    var tree1;
    +    if(!shell.which('npm')) {
    --- End diff --
    Judging from previous experience with our tools not being able to find ANDROID_HOME/JAVA_HOME
- this might become an error message that will affect new people. We should consider doing
a best effort to find the npm installed on the system if `which` can't find it. There are
some well known places on Windows/Mac where this gets installed.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message