cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vladimir-kotikov <>
Subject [GitHub] cordova-lib pull request: CB-10328 set top-level property of plugi...
Date Sat, 05 Mar 2016 11:37:29 GMT
Github user vladimir-kotikov commented on a diff in the pull request:
    --- Diff: cordova-lib/src/plugman/install.js ---
    @@ -71,7 +71,8 @@ module.exports = function installPlugin(platform, project_dir, id, plugins_dir,
         project_dir = cordovaUtil.convertToRealPathSafe(project_dir);
         plugins_dir = cordovaUtil.convertToRealPathSafe(plugins_dir);
         options = options || {};
    -    options.is_top_level = true;
    +    if (options.is_top_level === undefined)
    --- End diff --
    I meant that IMO the purpose of this check is to validate id someone already specified
this value, and in this case it's beter to use `hasOwnProperty` which does exactly what it

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message